<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">











<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <title>Entity Bus REST Implementation - FindBugs Bug Detector Report</title>
    <style type="text/css" media="all">
      @import url("./css/maven-base.css");
      @import url("./css/maven-theme.css");
      @import url("./css/site.css");
    </style>
    <link rel="stylesheet" href="./css/print.css" type="text/css" media="print" />
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
      </head>
  <body class="composite">
    <div id="banner">
                    <span id="bannerLeft">
    
            Entity Bus REST Implementation
    
            </span>
                    <div class="clear">
        <hr/>
      </div>
    </div>
    <div id="breadcrumbs">
          
  

  
    
  
  
    
            <div class="xleft">
        Last Published: 2009-01-29
                      </div>
            <div class="xright">            <a href="">Entity Bus REST Implementation</a>
            
  

  
    
  
  
    
  </div>
      <div class="clear">
        <hr/>
      </div>
    </div>
    <div id="leftColumn">
      <div id="navcolumn">
           
  

  
    
  
  
    
                             <h5>Project Documentation</h5>
            <ul>
              
                
              
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
            
      
              
        <li class="collapsed">
                    <a href="project-info.html">Project Information</a>
                </li>
              
                
              
      
            
      
            
            
            
      
            
      
            
      
            
      
              
            <li class="expanded">
                    <a href="project-reports.html">Project Reports</a>
                  <ul>
                  
    <li class="none">
                    <a href="checkstyle.html">Checkstyle</a>
          </li>
                  
    <li class="none">
                    <a href="cobertura/index.html">Cobertura Test Coverage</a>
          </li>
                  
    <li class="none">
              <strong>FindBugs Report</strong>
        </li>
                  
    <li class="none">
                    <a href="jdepend-report.html">JDepend</a>
          </li>
                  
    <li class="none">
                    <a href="jxr.html">Source Xref</a>
          </li>
                  
    <li class="none">
                    <a href="surefire-report.html">Surefire Report</a>
          </li>
                  
    <li class="none">
                    <a href="taglist.html">Tag List</a>
          </li>
              </ul>
        </li>
          </ul>
                                           <a href="http://maven.apache.org/" title="Built by Maven" class="poweredBy">
            <img alt="Built by Maven" src="./images/logos/maven-feather.png"></img>
          </a>
                       
  

  
    
  
  
    
        </div>
    </div>
    <div id="bodyColumn">
      <div id="contentBox">
        <div class="section"><h2>FindBugs Bug Detector Report</h2>
<p>The following document contains the results of <a class="externalLink" href="http://findbugs.sourceforge.net">FindBugs Report</a>
</p>
<p>FindBugs Version is <i>1.2.1</i>
</p>
<p>Threshold is <i>Low</i>
</p>
<p>Effort is <i>Default</i>
</p>
</div>
<div class="section"><h2>Summary</h2>
<table class="bodyTable"><tr class="a"><th>Classes</th>
<th>Bugs</th>
<th>Errors</th>
<th>Missing Classes</th>
</tr>
<tr class="b"><td>164</td>
<td>18</td>
<td>0</td>
<td>0</td>
</tr>
</table>
</div>
<div class="section"><h2>Files</h2>
<table class="bodyTable"><tr class="a"><th>Class</th>
<th>Bugs</th>
</tr>
<tr class="b"><td><a href="#org.sakaiproject.entitybus.rest.EntityBatchHandler">org.sakaiproject.entitybus.rest.EntityBatchHandler</a>
</td>
<td>5</td>
</tr>
<tr class="a"><td><a href="#org.sakaiproject.entitybus.rest.EntityDescriptionManager">org.sakaiproject.entitybus.rest.EntityDescriptionManager</a>
</td>
<td>7</td>
</tr>
<tr class="b"><td><a href="#org.sakaiproject.entitybus.rest.EntityDescriptionManager$1">org.sakaiproject.entitybus.rest.EntityDescriptionManager$1</a>
</td>
<td>1</td>
</tr>
<tr class="a"><td><a href="#org.sakaiproject.entitybus.rest.EntityDescriptionManager$2">org.sakaiproject.entitybus.rest.EntityDescriptionManager$2</a>
</td>
<td>1</td>
</tr>
<tr class="b"><td><a href="#org.sakaiproject.entitybus.rest.EntityEncodingManager">org.sakaiproject.entitybus.rest.EntityEncodingManager</a>
</td>
<td>3</td>
</tr>
<tr class="a"><td><a href="#org.sakaiproject.entitybus.rest.EntityRedirectsManager">org.sakaiproject.entitybus.rest.EntityRedirectsManager</a>
</td>
<td>1</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityBatchHandler"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityBatchHandler</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>Dead store to failure in org.sakaiproject.entitybus.rest.EntityBatchHandler.handleBatch(EntityView, HttpServletRequest, HttpServletResponse)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#DLS_DEAD_LOCAL_STORE">DLS_DEAD_LOCAL_STORE</a>
</td>
<td>284</td>
</tr>
<tr class="b"><td>Use of non-localized String.toUpperCase() or String.toLowerCase</td>
<td>I18N</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE">DM_CONVERT_CASE</a>
</td>
<td>148</td>
</tr>
<tr class="a"><td>Redundant nullcheck of clientWrapper which is known to be null in org.sakaiproject.entitybus.rest.EntityBatchHandler.handleBatch(EntityView, HttpServletRequest, HttpServletResponse)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE</a>
</td>
<td>275</td>
</tr>
<tr class="b"><td>EntityBatchHandler.entityRequestHandler not initialized in constructor</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR</a>
</td>
<td>Not available</td>
</tr>
<tr class="a"><td>Method org.sakaiproject.entitybus.rest.EntityBatchHandler.extractReferenceParams(HttpServletRequest, HttpRESTUtils$Method, String[]) makes inefficient use of keySet iterator instead of entrySet iterator</td>
<td>PERFORMANCE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR">WMI_WRONG_MAP_ITERATOR</a>
</td>
<td>382</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityDescriptionManager"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityDescriptionManager</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>Dead store to html in org.sakaiproject.entitybus.rest.EntityDescriptionManager.makeRedirectLink(String, String)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#DLS_DEAD_LOCAL_STORE">DLS_DEAD_LOCAL_STORE</a>
</td>
<td>876</td>
</tr>
<tr class="b"><td>org.sakaiproject.entitybus.rest.EntityDescriptionManager.ACTION_KEY_PREFIX isn't final but should be</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL">MS_SHOULD_BE_FINAL</a>
</td>
<td>84</td>
</tr>
<tr class="a"><td>org.sakaiproject.entitybus.rest.EntityDescriptionManager.DESCRIBE isn't final but should be</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL">MS_SHOULD_BE_FINAL</a>
</td>
<td>85</td>
</tr>
<tr class="b"><td>org.sakaiproject.entitybus.rest.EntityDescriptionManager.FAKE_ID isn't final but should be</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL">MS_SHOULD_BE_FINAL</a>
</td>
<td>87</td>
</tr>
<tr class="a"><td>org.sakaiproject.entitybus.rest.EntityDescriptionManager.SLASH_DESCRIBE isn't final but should be</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL">MS_SHOULD_BE_FINAL</a>
</td>
<td>86</td>
</tr>
<tr class="b"><td>Load of known null value in org.sakaiproject.entitybus.rest.EntityDescriptionManager.makeActionURL(EntityView, CustomAction)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_LOAD_OF_KNOWN_NULL_VALUE">NP_LOAD_OF_KNOWN_NULL_VALUE</a>
</td>
<td>911</td>
</tr>
<tr class="a"><td>org.sakaiproject.entitybus.rest.EntityDescriptionManager.makeRedirectLink(String, String) checks to see if result of String.indexOf is positive</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_CHECK_FOR_POSITIVE_INDEXOF">RV_CHECK_FOR_POSITIVE_INDEXOF</a>
</td>
<td>877</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityDescriptionManager1"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityDescriptionManager$1</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>The class org.sakaiproject.entitybus.rest.EntityDescriptionManager$1 could be refactored into a named _static_ inner class</td>
<td>PERFORMANCE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON">SIC_INNER_SHOULD_BE_STATIC_ANON</a>
</td>
<td>139-145</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityDescriptionManager2"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityDescriptionManager$2</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>The class org.sakaiproject.entitybus.rest.EntityDescriptionManager$2 could be refactored into a named _static_ inner class</td>
<td>PERFORMANCE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON">SIC_INNER_SHOULD_BE_STATIC_ANON</a>
</td>
<td>152-161</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityEncodingManager"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityEncodingManager</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>org.sakaiproject.entitybus.rest.EntityEncodingManager.HANDLED_INPUT_FORMATS should be package protected</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_PKGPROTECT">MS_PKGPROTECT</a>
</td>
<td>80</td>
</tr>
<tr class="b"><td>org.sakaiproject.entitybus.rest.EntityEncodingManager.HANDLED_OUTPUT_FORMATS should be package protected</td>
<td>MALICIOUS_CODE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_PKGPROTECT">MS_PKGPROTECT</a>
</td>
<td>81</td>
</tr>
<tr class="a"><td>Redundant nullcheck of transcoder, which is known to be non-null in org.sakaiproject.entitybus.rest.EntityEncodingManager.setTranscoder(Transcoder)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE</a>
</td>
<td>589</td>
</tr>
</table>
</div>
<a name="org.sakaiproject.entitybus.rest.EntityRedirectsManager"></a>
<div class="section"><h3>org.sakaiproject.entitybus.rest.EntityRedirectsManager</h3>
<table class="bodyTable"><tr class="b"><th>Bug</th>
<th>Category</th>
<th>Details</th>
<th>Line</th>
</tr>
<tr class="a"><td>Unchecked/unconfirmed cast from org.sakaiproject.entitybus.entityprovider.EntityProvider to org.sakaiproject.entitybus.entityprovider.capabilities.RedirectControllable in org.sakaiproject.entitybus.rest.EntityRedirectsManager.checkForTemplateMatch(EntityProvider, String, String)</td>
<td>STYLE</td>
<td><a class="externalLink" href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_UNCONFIRMED_CAST">BC_UNCONFIRMED_CAST</a>
</td>
<td>162</td>
</tr>
</table>
</div>

      </div>
    </div>
    <div class="clear">
      <hr/>
    </div>
    <div id="footer">
      <div class="xright">&#169;  
          2007-2009
    
          Sakai Project
          
  

  
    
  
  
    
  </div>
      <div class="clear">
        <hr/>
      </div>
    </div>
  </body>
</html>
